Skip to content

COM-2479: Добавил возможность использовать csssr.images без изменения размера изображений#101

Merged
vkosinov merged 12 commits intomasterfrom
COM-2479
Aug 25, 2020
Merged

COM-2479: Добавил возможность использовать csssr.images без изменения размера изображений#101
vkosinov merged 12 commits intomasterfrom
COM-2479

Conversation

@vkosinov
Copy link
Copy Markdown
Contributor

@vkosinov vkosinov commented Aug 21, 2020

ссылка на jira: COM-2479

@vkosinov vkosinov requested a review from Yankovsky August 21, 2020 13:42
@vkosinov vkosinov self-assigned this Aug 21, 2020
Yankovsky
Yankovsky suggested changes Aug 21, 2020
View reviewed changes
Comment thread src/utils/getPixelRations.ts
Comment thread src/webpack/loader.ts
Comment thread src/webpack/loaderOptionsSchema.ts
Comment thread src/webpack/loader.ts Outdated
Comment thread src/webpack/loader.ts Outdated
Comment thread src/webpack/imgproxyUrlBuilder.ts Outdated
Comment thread src/utils/getCompressionRatio.ts
Yankovsky and others added 2 commits August 21, 2020 22:35
@Yankovsky
improve typings
a0e2998
@vkosinov
COM-2479:
820d213 
- refactoring backgroundCss, add tests
- add tests getCompressionRatio
- add getOriginalExtensionSrcSet, add test
- refactoring dev mode
- originalPixelRatio typing refactoring
@vkosinov vkosinov requested a review from Yankovsky August 24, 2020 16:06
Yankovsky
Yankovsky suggested changes Aug 24, 2020
View reviewed changes
Comment thread src/utils/__tests__/getCompressionRatio.ts Outdated
Comment thread src/webpack/loader.ts Outdated
Comment thread src/webpack/loader.ts Outdated
Yankovsky and others added 3 commits August 25, 2020 09:55
@Yankovsky
Fixed incorrect check that interpret 0 as falsy value
9c2a469
@vkosinov
COM-2479:
8b2dfa4 
- add rounding to getCompressionRatio
- rename getPixelRations -> getPixelRatios
- refactoring use getOriginalExtensionSrcSet
@vkosinov
Merge branch 'master' into COM-2479
4760f22
@vkosinov vkosinov requested a review from Yankovsky August 25, 2020 07:40
@vkosinov vkosinov merged commit bd14371 into master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Yankovsky Yankovsky Yankovsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vkosinov vkosinov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkosinov @Yankovsky